@AlpinDale Thanks, this looks good to me. Could we add a test?

Thanks for the review @Yard1. It needs a bit more work, could probably use a mask and an unsqueeze for the factor/curve. I'll finish this up soon and add a test unit.

@Yard1 Should be done, let me know if there's any issues. Correctness tests pass for the new sampler.

Hey @AlpinDale there seems to be an error in the test (the condition is not being met) that was hidden before as logits was modified in place. Could you take a look?

Also the condition itself is very brittle - it would be better to compare the output to some reference.

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

This pull request has merge conflicts that must be resolved before it can be
merged. @AlpinDale please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@AlpinDale do you plan to continue this line of work?

@AlpinDale do you plan to continue this line of work?

This sampler is quite outdated by now, so I'm not sure it'll be a useful addition anymore. There are better alternatives.

Ok, thank you for the update!